Upgrade go to 1.18

[odedlaz]

We're currently using go 1.17 which was released a year ago and is no longer supported
1.18 was released 5 months ago and is battle tested, in contrast to 1.19 which was released a week ago.

This PR upgrades to 1.18 + I ran go mod tidy. It's related to:

• Upgrade golang to 1.18 charts#145
• Upgrade go to 1.18 devenv#99
• Upgrade go to 1.18 pipeline-with-terraform#2

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[odedlaz]

@jLopezbarb , I think I can't update the CircleCI executor from 1.17 -> 1.18 since it uses an internal image: okteto/golang-ci.

[jLopezbarb]

I''ve opened a PR to update okteto/golang-ci and use the new image. We'll notify your when it's updated

[jLopezbarb]

@odedlaz could you pin okteto/golang-ci to 1.18.0 on all the PRs? I've created the tag and since there are more projects that use okteto/golang-ci pinning the specific version is the best option

[odedlaz]

@odedlaz could you pin okteto/golang-ci to 1.18.0 on all the PRs? I've created the tag and since there are more projects that use okteto/golang-ci pinning the specific version is the best option

@jLopezbarb , 1.18.0 is quite old (released 15 Mar 22, the latest 1.18.5 was released 1 Aug 22). If you want to pin a minor, maybe pin the latest minor? or maybe go straight to 1.19.0? what do you think?

[jLopezbarb]

@odedlaz could you pin okteto/golang-ci to 1.18.0 on all the PRs? I've created the tag and since there are more projects that use okteto/golang-ci pinning the specific version is the best option

@jLopezbarb , 1.18.0 is quite old (released 15 Mar 22, the latest 1.18.5 was released 1 Aug 22). If you want to pin a minor, maybe pin the latest minor? or maybe go straight to 1.19.0? what do you think?

I meant the okteto/golang-ci image which is specified in .circleci/config.yml. I created okteto/golang-ci:1.8.0 image a couple of hours ago. It's already using Go1.18.5

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[rberrelleza]

I think the CI failure is due to https://status.circleci.com/incidents/3d31fnpthj7y. Waiting for circleci to restore functionality and we can try again.

[jLopezbarb]

@odedlaz Can you commit an empty commit?
git commit --allow-empty -m "Trigger ci"
CircleCI has resolved the issue but since we were affected we need to commit to force CircleCI to look for the config.yaml again

[odedlaz]

@odedlaz Can you commit an empty commit? git commit --allow-empty -m "Trigger ci" CircleCI has resolved the issue but since we were affected we need to commit to force CircleCI to look for the config.yaml again

done @jLopezbarb .

[ifbyol]

Thanks for the contribution @odedlaz !

[jpf-okteto]

I apologize for the noise (closing, labelling), some webhook events were lost during a recent CircleCI outage. It should be fine now.

[codecov]

Codecov Report

Merging #3016 (3a775ac) into master (3a59d8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3016   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         188      188           
  Lines       19748    19748           
=======================================
  Hits         6465     6465           
  Misses      12518    12518           
  Partials      765      765           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[odedlaz]

I apologize for the noise (closing, labelling), some webhook events were lost during a recent CircleCI outage. It should be fine now.

looks ok now. anything else I can do to help this get in?