fix: show warning msg when sanitize dev

[AdrianPedriza]

Fixes #2888

Proposed changes

• sanitize dev section

[codecov]

Codecov Report

Merging #3021 (5ba9a1b) into master (df13ed4) will increase coverage by 0.01%.
The diff coverage is 61.70%.

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
+ Coverage   32.72%   32.73%   +0.01%     
==========================================
  Files         188      188              
  Lines       19743    19773      +30     
==========================================
+ Hits         6460     6473      +13     
- Misses      12519    12532      +13     
- Partials      764      768       +4     

Impacted Files	Coverage Δ
cmd/up/up.go	10.71% <ø> (ø)
pkg/cmd/stack/deploy.go	25.86% <0.00%> (ø)
pkg/model/manifest.go	26.10% <48.27%> (+0.76%)	⬆️
pkg/model/serializer.go	67.52% <88.23%> (-0.14%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[AdrianPedriza]

the main problem with the needed solution is to find a proper way to show the user all the sanitized warnings in a friendly manner.

Current display:

[AdrianPedriza]

the main problem with the needed solution is to find a proper way to show the user all the sanitized warnings in a friendly manner.

Current display:

after discussing with @jLopezbarb about what should be the proper way to show the user this type of warning, as a temporary solution before the manifest parsing refactor we agree to display the user two kinds of warnings: one for okteto manifest and another one for compose files.

[jLopezbarb]

@AdrianPedriza Could you post a screenshot of the final result?

[AdrianPedriza]

@AdrianPedriza Could you post a screenshot of the final result?

sure.

for okteto up

for okteto deploy

[jLopezbarb]

@AdrianPedriza Could you post a screenshot of the final result?

sure.

for okteto up

for okteto deploy

I'd mention in the okteto deploy that the second message is referencing a compose file, but other than that looks good to me

[AdrianPedriza]

@AdrianPedriza Could you post a screenshot of the final result?

sure.
for okteto up

for okteto deploy

I'd mention in the okteto deploy that the second message is referencing a compose file, but other than that looks good to me

yes, sorry it was an old pic. Check it now, I have edited the pic!

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[jLopezbarb]

I forgot to mention that this PR needs to update docs

[AdrianPedriza]

I forgot to mention that this PR needs to update docs

where?

[jLopezbarb]

I forgot to mention that this PR needs to update docs

where?

https://github.com/okteto/docs

[AdrianPedriza]

I forgot to mention that this PR needs to update docs

where?

https://github.com/okteto/docs

I mean, in which parts of docs we could talk about this kind of warnings?

[AdrianPedriza]

I forgot to mention that this PR needs to update docs

where?

https://github.com/okteto/docs

I mean, in which parts of docs we could talk about this kind of warnings?

I know what you mean know. I have created this issue due to at the moment we need to wait for other PR to be integrated into docs.