-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev selector typo #3033
Fix dev selector typo #3033
Conversation
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
- Coverage 32.79% 32.75% -0.04%
==========================================
Files 188 188
Lines 19762 19788 +26
==========================================
+ Hits 6480 6481 +1
- Misses 12517 12543 +26
+ Partials 765 764 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
Signed-off-by: Teresa Romero <teresa@okteto.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rlamana @RinkiyaKeDad Can you review the text for the elector on each situation, please?
} | ||
} | ||
|
||
func SelectDevFromManifest(manifest *model.Manifest, label string) (*model.Dev, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include a comment in this exported function, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added suggestions for the messages.
Another thing I was thinking was that we could just change all the messages to "Select a development container:" - since the user running the command would know from the command itself what exactly they are selecting the container for. What do you all think?
Signed-off-by: Teresa Romero <teresa@okteto.com>
@RinkiyaKeDad Thnks for the suggestions! I've fixed the strings accordingly. Regarding the message, i think adding the action that is being performed, although the user knows from the command, is more descriptive. |
Signed-off-by: Teresa Romero <teresa@okteto.com>
Fixes #2778
Proposed changes