-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow okteto destroy on deploy cmd #3037
Merged
jLopezbarb
merged 13 commits into
master
from
jlopezbarb/allow-okteto-destroy-on-deploy-cmd
Sep 5, 2022
Merged
allow okteto destroy on deploy cmd #3037
jLopezbarb
merged 13 commits into
master
from
jlopezbarb/allow-okteto-destroy-on-deploy-cmd
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
commented
Aug 25, 2022
I still need to create an e2e testing this functionality |
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
=======================================
Coverage 32.80% 32.81%
=======================================
Files 188 189 +1
Lines 19792 19812 +20
=======================================
+ Hits 6493 6501 +8
- Misses 12530 12542 +12
Partials 769 769
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
teresaromero
approved these changes
Aug 29, 2022
ifbyol
reviewed
Aug 29, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
AdrianPedriza
approved these changes
Aug 30, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
ifbyol
reviewed
Aug 31, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
ifbyol
approved these changes
Sep 1, 2022
AdrianPedriza
approved these changes
Sep 1, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2762
Proposed changes
okteto deploy
temp kubeconfig