Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow okteto destroy on deploy cmd #3037

Merged
merged 13 commits into from
Sep 5, 2022

Conversation

jLopezbarb
Copy link
Contributor

Fixes #2762

Proposed changes

  • Fixes path on native windows
  • Modify destroy temp kubeconfig name to not collide with okteto deploy temp kubeconfig
  • If okteto destroy inside okteto deploy it will skip the destruction of the configmap

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team August 25, 2022 11:40
@jLopezbarb
Copy link
Contributor Author

I still need to create an e2e testing this functionality

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #3037 (ece85ae) into master (677f454) will increase coverage by 0.00%.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   32.80%   32.81%           
=======================================
  Files         188      189    +1     
  Lines       19792    19812   +20     
=======================================
+ Hits         6493     6501    +8     
- Misses      12530    12542   +12     
  Partials      769      769           
Impacted Files Coverage Δ
cmd/deploy/deploy.go 27.32% <ø> (ø)
cmd/deploy/kubeconfig.go 0.00% <0.00%> (ø)
cmd/destroy/destroy.go 40.65% <8.33%> (-1.60%) ⬇️
cmd/destroy/runners.go 61.11% <61.11%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb changed the title Jlopezbarb/allow okteto destroy on deploy cmd allow okteto destroy on deploy cmd Aug 25, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
cmd/destroy/destroy.go Show resolved Hide resolved
cmd/destroy/destroy.go Outdated Show resolved Hide resolved
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
cmd/destroy/destroy_test.go Show resolved Hide resolved
cmd/destroy/destroy_test.go Outdated Show resolved Hide resolved
Signed-off-by: Javier López Barba <javier@okteto.com>
cmd/deploy/kubeconfig.go Outdated Show resolved Hide resolved
cmd/destroy/runners.go Outdated Show resolved Hide resolved
cmd/destroy/destroy.go Outdated Show resolved Hide resolved
cmd/destroy/destroy_test.go Show resolved Hide resolved
cmd/destroy/runners.go Outdated Show resolved Hide resolved
cmd/destroy/runners.go Outdated Show resolved Hide resolved
cmd/destroy/runners.go Outdated Show resolved Hide resolved
cmd/destroy/runners.go Outdated Show resolved Hide resolved
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb merged commit ffc67b5 into master Sep 5, 2022
@jLopezbarb jLopezbarb deleted the jlopezbarb/allow-okteto-destroy-on-deploy-cmd branch September 5, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for running okteto destroy in the deploy section of the okteto manifest
4 participants