fix secrets replacement when okteto build #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianPedriza
force-pushed
the
adrian/fix-secrets-replacement-when-okteto-build
branch
from
2bc417c
to
0551e25
Compare
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
AdrianPedriza
force-pushed
the
adrian/fix-secrets-replacement-when-okteto-build
branch
from
0551e25
to
8a6da4b
Compare
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
ifbyol
reviewed
Sep 1, 2022
|
Would it makes sense to create an e2e tests for this? (it could be in a follow up PR to unblock the fix) |
|
… manifest Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
ifbyol
reviewed
Sep 2, 2022
Signed-off-by: adripedriza <adripedriza@gmail.com>
AdrianPedriza
force-pushed
the
adrian/fix-secrets-replacement-when-okteto-build
branch
from
13d86d3
to
cb3cd66
Compare
Signed-off-by: adripedriza <adripedriza@gmail.com>
…thub.com:okteto/okteto into adrian/fix-secrets-replacement-when-okteto-build Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
AdrianPedriza
force-pushed
the
adrian/fix-secrets-replacement-when-okteto-build
branch
from
413820c
to
950516e
Compare
jLopezbarb
reviewed
Sep 2, 2022
jLopezbarb
reviewed
Sep 2, 2022
jLopezbarb
reviewed
Sep 2, 2022
AdrianPedriza
commented
Sep 2, 2022
Signed-off-by: adripedriza <adripedriza@gmail.com>
jLopezbarb
reviewed
Sep 5, 2022
jLopezbarb
reviewed
Sep 5, 2022
jLopezbarb
approved these changes
Sep 5, 2022
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
jLopezbarb
approved these changes
Sep 5, 2022
teresaromero
approved these changes
Sep 5, 2022
AdrianPedriza
deleted the
adrian/fix-secrets-replacement-when-okteto-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secrets are not resolved when
okteto buildrunsFixes #3044
Proposed changes**
Context: Secrets are resolved once context is loaded so solution to be able to resolve properly secrets inside a manifest is needed to run load context before read a manifest.
loadContextbefore callGetManifestloadContexthas a general implementation, regardless of the version of the loaded manifest.manifest v1once the builder is obtained