Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix external resource markdown able to generate it dinamycally using … #4076

Conversation

AdrianPedriza
Copy link
Contributor

@AdrianPedriza AdrianPedriza commented Nov 30, 2023

…deploy section

Proposed changes

  • read external markdown after run deploy section in order to benefit from any modification of the file during that step

How to validate

Captura de pantalla 2023-11-30 a las 13 09 13
  • to run okteto deploy --remote, you will need to build this cli version and use that image name here. Result should be same as running okteto deploy

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

…deploy section

Signed-off-by: adrianpedriza <adripedriza@gmail.com>
@AdrianPedriza AdrianPedriza requested a review from a team November 30, 2023 12:09
@AdrianPedriza AdrianPedriza changed the title fix external resource markdown able to generate in dinamycally using … fix external resource markdown able to generate it dinamycally using … Nov 30, 2023
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected with okteto deploy and okteto deploy --remote

Code change LGTM 👏

@AdrianPedriza AdrianPedriza merged commit 022d79b into master Nov 30, 2023
22 checks passed
@AdrianPedriza AdrianPedriza deleted the LAKE-97-external-resources-markdown-cannot-be-created-dynamically branch November 30, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants