Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double warning on --insecure-skip-tls-verify #4171

Merged
merged 1 commit into from Feb 15, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

DEV-139

We updated the cobra dependency and now the library takes care of all the parents PersistentPreRuns, so there is no need on having the code that we removed on this PR.

TLDR: We have 2 duplicated log messages, one managed by us and another one by the cobra dependency. Now cobra is the one managing it

How to validate

  1. Run okteto context use $URL --insecure-skip-tls-verify
  2. Check that there is no duplicated message

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner February 6, 2024 10:04
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #4171 (82aa836) into master (c6b78f4) will decrease coverage by 0.02%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
- Coverage   45.58%   45.57%   -0.02%     
==========================================
  Files         287      287              
  Lines       27052    27050       -2     
==========================================
- Hits        12333    12327       -6     
- Misses      13635    13637       +2     
- Partials     1084     1086       +2     

@jLopezbarb jLopezbarb merged commit 92500c0 into master Feb 15, 2024
16 of 17 checks passed
@jLopezbarb jLopezbarb deleted the jlopezbarb/fix-double-warning branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants