Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getting started copy and update getting started samples #4215

Merged
merged 20 commits into from
Apr 15, 2024

Conversation

codyjlandstrom
Copy link
Contributor

Proposed changes

Fixes # (issue)

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

How to validate

Please provide step-by-step instructions to replicate your validation scenario. For bug fixes, detail how to reproduce both the bug and its fix, along with any observations.

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@derek derek bot added the new-contributor label Apr 3, 2024
Copy link

derek bot commented Apr 3, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

馃挕 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@derek derek bot added the no-dco label Apr 3, 2024
Signed-off-by: Cody Landstrom <cody@okteto.com>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #4215 (2dd7ea5) into master (1b7dce4) will decrease coverage by 0.03%.
Report is 18 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4215      +/-   ##
==========================================
- Coverage   45.51%   45.49%   -0.03%     
==========================================
  Files         295      295              
  Lines       27288    27288              
==========================================
- Hits        12420    12414       -6     
- Misses      13806    13810       +4     
- Partials     1062     1064       +2     

@codyjlandstrom codyjlandstrom marked this pull request as ready for review April 12, 2024 14:27
@codyjlandstrom codyjlandstrom requested a review from a team as a code owner April 12, 2024 14:27
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
| **Secrets Management** | Not Available | Available |
| **Observability Tools** | Not Available | Available |
| **Support** | Community Support | Professional Support|
| **Documentation** | [Open Source Docs](https://www.okteto.com/docs/get-started/install-okteto-cli/) | [Platform Docs](https://www.okteto.com/docs/) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a clear link for Open Source Docs. Maybe adding a small samplesREADME.md? The samples` folder in this PR is the only one with docs/samples for Open Source CLI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a samples readme and linked to it from this section. Let me know what you think of it

@pchico83 pchico83 merged commit ce40a2a into master Apr 15, 2024
11 of 12 checks passed
@pchico83 pchico83 deleted the pchico83/samples branch April 15, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants