-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve getting started copy and update getting started samples #4215
Conversation
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 馃挕 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Signed-off-by: Cody Landstrom <cody@okteto.com>
1409811
to
0b8f2e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4215 +/- ##
==========================================
- Coverage 45.51% 45.49% -0.03%
==========================================
Files 295 295
Lines 27288 27288
==========================================
- Hits 12420 12414 -6
- Misses 13806 13810 +4
- Partials 1062 1064 +2 |
README.md
Outdated
| **Secrets Management** | Not Available | Available | | ||
| **Observability Tools** | Not Available | Available | | ||
| **Support** | Community Support | Professional Support| | ||
| **Documentation** | [Open Source Docs](https://www.okteto.com/docs/get-started/install-okteto-cli/) | [Platform Docs](https://www.okteto.com/docs/) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a clear link for Open Source Docs
. Maybe adding a small samples
README.md? The
samples` folder in this PR is the only one with docs/samples for Open Source CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a samples readme and linked to it from this section. Let me know what you think of it
Proposed changes
Fixes # (issue)
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
How to validate
Please provide step-by-step instructions to replicate your validation scenario. For bug fixes, detail how to reproduce both the bug and its fix, along with any observations.
CLI Quality Reminders 馃敡
For both authors and reviewers: