Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log on ui #4229

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: log on ui #4229

merged 1 commit into from
Apr 11, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Fixes the following log:

Before Now
Screenshot 2024-04-11 at 12 49 04 Screenshot 2024-04-11 at 12 58 19

How to validate

  1. Deploy any repo on okteto
  2. Check UI

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
fix: log on ui
439784b 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner April 11, 2024 10:59
@jLopezbarb jLopezbarb added the backport release-2.26 Backport this PR to CLI version 2.26 label Apr 11, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #4229 (439784b) into master (4fcf9fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4229      +/-   ##
==========================================
+ Coverage   45.66%   45.69%   +0.02%     
==========================================
  Files         303      303              
  Lines       27539    27539              
==========================================
+ Hits        12577    12583       +6     
+ Misses      13889    13885       -4     
+ Partials     1073     1071       -2

@jLopezbarb jLopezbarb merged commit d2065c3 into master Apr 11, 2024
22 checks passed
@jLopezbarb jLopezbarb deleted the jlo/fix-log-on-ui branch April 11, 2024 11:03
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@jLopezbarb @github-actions
fix: log on ui (#4229)
6017350 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit d2065c3)
jLopezbarb added a commit that referenced this pull request Apr 11, 2024
@github-actions @jLopezbarb
fix: log on ui (#4229) (#4230)
4f05582 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit d2065c3)

Co-authored-by: Javier L贸pez Barba <javier@okteto.com>
@BrewTestBot BrewTestBot mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
backport release-2.26 Backport this PR to CLI version 2.26 release/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jLopezbarb @ifbyol