Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repo with double url #4237

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: repo with double url #4237

merged 1 commit into from
Apr 12, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Detected a bug where the repository URL could have double slash, making it weir in the UI and preventing to group the insights by repo.

Before Now
Screenshot 2024-04-12 at 12 56 54 Screenshot 2024-04-12 at 13 00 52

How to validate

There are two different scenarios

  1. Run git clone https://github.com//okteto/movies or git clone https://github.com/okteto//movies
  2. Run cd movies
  3. Run okteto deploy
  4. Run kubectl get events.events.k8s.io -levents.okteto.com=true and check that the repository is correct

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
fix: repo with double url
b1a7da0 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb added release/bug-fix backport release-2.26 Backport this PR to CLI version 2.26 labels Apr 12, 2024
@jLopezbarb jLopezbarb requested a review from a team as a code owner April 12, 2024 11:05
@jLopezbarb jLopezbarb merged commit fef38ea into master Apr 12, 2024
20 of 21 checks passed
@jLopezbarb jLopezbarb deleted the jlo/fix-double-slash-repo-url branch April 12, 2024 13:03
github-actions bot pushed a commit that referenced this pull request Apr 12, 2024
@jLopezbarb @github-actions
fix: repo with double url (#4237)
bd0adb1 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit fef38ea)
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
Merged
jLopezbarb added a commit that referenced this pull request Apr 12, 2024
@github-actions @jLopezbarb
fix: repo with double url (#4237) (#4238)
bd77b46 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit fef38ea)

Co-authored-by: Javier L贸pez Barba <javier@okteto.com>
@BrewTestBot BrewTestBot mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreafalzetti andreafalzetti andreafalzetti approved these changes

Assignees
No one assigned
Labels
backport release-2.26 Backport this PR to CLI version 2.26 release/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jLopezbarb @andreafalzetti