Support variable expansion in .env
: "VAR1=${VAR2:-default}"
#4239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-279
Currently, the
.env
does not support default values for variables. The library go-dotenv doesn't support the notationVAR="${VAR:-default}"
. (see joho/godotenv#211).With this change the Okteto CLI will be able to expand the vars in the
.env
adding support for such scenario.How to validate
.env
file:okteto deploy
TEST
andKEY
are populated correctly, whileANDREA
is:-foo}
Repeat the steps with the changes and observe how all vars work as expected, by default you should get
ANDREA=foo
. If you runANDREA_DEAULT=testvalue okd deploy
observe the valueANDREA=testvalue
in the output.CLI Quality Reminders 馃敡
For both authors and reviewers: