-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
okteto up
: display warning when available disk space is running low
#4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
@codyjlandstrom @pchico83 do you have any feedback on the copy of the warning and spinner? |
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4262 +/- ##
==========================================
- Coverage 45.65% 45.58% -0.08%
==========================================
Files 306 306
Lines 27676 27707 +31
==========================================
- Hits 12635 12629 -6
- Misses 13963 13998 +35
- Partials 1078 1080 +2 |
No comments. The warning sounds great! |
pchico83
approved these changes
Apr 24, 2024
ifbyol
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-316
If a user has very low available disk space (< 1%) syncthing is at risk of failing, therefore the
okteto up
sessions can result in a bad experence.With this PR we aim to inform the users that such scenario might happen, by warning them that their disk is almost full.
How to validate
Similar to #4261
CLI Quality Reminders 馃敡
For both authors and reviewers: