Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

okteto up: display warning when available disk space is running low #4262

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Apr 24, 2024

Proposed changes

Fixes DEV-316

If a user has very low available disk space (< 1%) syncthing is at risk of failing, therefore the okteto up sessions can result in a bad experence.

With this PR we aim to inform the users that such scenario might happen, by warning them that their disk is almost full.

Screenshot 2024-04-24 at 16 58 35

How to validate

Similar to #4261

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Apr 24, 2024

@codyjlandstrom @pchico83 do you have any feedback on the copy of the warning and spinner?

Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Merging #4262 (5f79fb5) into master (cce75fc) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
- Coverage   45.65%   45.58%   -0.08%     
==========================================
  Files         306      306              
  Lines       27676    27707      +31     
==========================================
- Hits        12635    12629       -6     
- Misses      13963    13998      +35     
- Partials     1078     1080       +2     

@codyjlandstrom
Copy link
Contributor

@codyjlandstrom @pchico83 do you have any feedback on the copy of the warning and spinner?

No comments. The warning sounds great!

@andreafalzetti andreafalzetti marked this pull request as ready for review April 26, 2024 07:45
@andreafalzetti andreafalzetti requested a review from a team as a code owner April 26, 2024 07:45
@andreafalzetti andreafalzetti merged commit 54b3471 into master Apr 26, 2024
11 of 12 checks passed
@andreafalzetti andreafalzetti deleted the af/dev-316-syncthing-out-of-space branch April 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants