Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont include dockerfilepath for hash calculation #4271

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Fixes DEV-321

How to validate

  1. Create the following okteto.yml:
services:
  nginx:
    image: nginx
    volumes: 
    - proxy:/etc/nginx/conf.d
  1. Check that okteto build builds
  2. Check that okteto build uses the smart build logic

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner April 29, 2024 17:04
@jLopezbarb jLopezbarb merged commit 991b7e7 into master Apr 30, 2024
16 checks passed
@jLopezbarb jLopezbarb deleted the jlo/remove-dockerfile-path-for-hash-calculation branch April 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants