Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry builds on depot #4285

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Transient errors on depot were broken. We were trying to reuse the machine that was already used for the previous build which was unavailable

How to validate

I couldn't figure out how to force a transient error on depot. Here are the steps followed in order to test it.

  1. Return always true on shouldRetry func: https://github.com/okteto/okteto/compare/jlo/fix-retry-builds-on-depot?expand=1#diff-13e727e603e4c9bb0fc05b1f058dc88b9a1d21aa410fdfd3659499086d6eb457R395
  2. Create a Dockerfile with a wrong step:
FROM okteto/pipeline-runner:1.0.2

RUN curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.18.3

RaUN echo exit 1
  1. Check that is retried

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner May 8, 2024 12:29
@jLopezbarb jLopezbarb added release/bug-fix backport release-2.27 Backport this PR to CLI version 2.27 labels May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 43.36%. Comparing base (535fdf3) to head (6f50c48).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4285      +/-   ##
==========================================
- Coverage   43.37%   43.36%   -0.01%     
==========================================
  Files         368      368              
  Lines       30012    30027      +15     
==========================================
+ Hits        13017    13022       +5     
- Misses      15876    15883       +7     
- Partials     1119     1122       +3     

@jLopezbarb jLopezbarb merged commit c7f0b9f into master May 8, 2024
21 of 22 checks passed
@jLopezbarb jLopezbarb deleted the jlo/fix-retry-builds-on-depot branch May 8, 2024 14:16
github-actions bot pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit c7f0b9f)
jLopezbarb added a commit that referenced this pull request May 8, 2024
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit c7f0b9f)

Co-authored-by: Javier L贸pez Barba <javier@okteto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.27 Backport this PR to CLI version 2.27 release/bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants