Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panics on command initialsation #4322

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: panics on command initialsation #4322

merged 2 commits into from
May 28, 2024

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier Lopez javier@okteto.com

Proposed changes

Fixes DEV-378

We have detected several panics that have been fixed on this PR. Summarising them in bullet points:

  1. okteto up:
    1.1 Fixes a panic when okteto up is executed on a manifest without dev section
    1.2 Fixes a panic when okteto up is executed on a folder without manifest and infering it
  2. okteto init
    2.1 Fixes a panic when okteto init has to deploy (need to click on yes)
    2.2 Fixes a panic when okteto init is set with k8sLogger

How to validate

Check that the scenarios described above are working without a panic

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner May 28, 2024 10:18
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb added release/bug-fix backport release-2.27 Backport this PR to CLI version 2.27 backport release-2.26 Backport this PR to CLI version 2.26 labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 43.05%. Comparing base (9837398) to head (ae908d5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4322   +/-   ##
=======================================
  Coverage   43.05%   43.05%           
=======================================
  Files         371      371           
  Lines       30048    30060   +12     
=======================================
+ Hits        12936    12942    +6     
- Misses      15978    15986    +8     
+ Partials     1134     1132    -2     

@jLopezbarb jLopezbarb merged commit ad8c37c into master May 28, 2024
25 of 27 checks passed
@jLopezbarb jLopezbarb deleted the jlo/dev-378 branch May 28, 2024 13:12
github-actions bot pushed a commit that referenced this pull request May 28, 2024
* fix: panics on command initialsation

Signed-off-by: Javier Lopez <javier@okteto.com>

* fix: panic

Signed-off-by: Javier Lopez <javier@okteto.com>

---------

Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit ad8c37c)
Copy link
Contributor

The backport to release-2.26 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.26 release-2.26
# Navigate to the new working tree
cd .worktrees/backport-release-2.26
# Create a new branch
git switch --create backport-4322-to-release-2.26
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ad8c37c3002a2b123134af95fd865b94b1101c0d
# Push it to GitHub
git push --set-upstream origin backport-4322-to-release-2.26
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.26

Then, create a pull request where the base branch is release-2.26 and the compare/head branch is backport-4322-to-release-2.26.

jLopezbarb added a commit that referenced this pull request May 29, 2024
* fix: panics on command initialsation

Signed-off-by: Javier Lopez <javier@okteto.com>

* fix: panic

Signed-off-by: Javier Lopez <javier@okteto.com>

---------

Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit ad8c37c)

Co-authored-by: Javier López Barba <javier@okteto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.26 Backport this PR to CLI version 2.26 backport release-2.27 Backport this PR to CLI version 2.27 release/bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants