-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panics on command initialsation #4322
Conversation
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4322 +/- ##
=======================================
Coverage 43.05% 43.05%
=======================================
Files 371 371
Lines 30048 30060 +12
=======================================
+ Hits 12936 12942 +6
- Misses 15978 15986 +8
+ Partials 1134 1132 -2 |
* fix: panics on command initialsation Signed-off-by: Javier Lopez <javier@okteto.com> * fix: panic Signed-off-by: Javier Lopez <javier@okteto.com> --------- Signed-off-by: Javier Lopez <javier@okteto.com> (cherry picked from commit ad8c37c)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.26 release-2.26
# Navigate to the new working tree
cd .worktrees/backport-release-2.26
# Create a new branch
git switch --create backport-4322-to-release-2.26
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ad8c37c3002a2b123134af95fd865b94b1101c0d
# Push it to GitHub
git push --set-upstream origin backport-4322-to-release-2.26
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.26 Then, create a pull request where the |
* fix: panics on command initialsation Signed-off-by: Javier Lopez <javier@okteto.com> * fix: panic Signed-off-by: Javier Lopez <javier@okteto.com> --------- Signed-off-by: Javier Lopez <javier@okteto.com> (cherry picked from commit ad8c37c) Co-authored-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier Lopez javier@okteto.com
Proposed changes
Fixes DEV-378
We have detected several panics that have been fixed on this PR. Summarising them in bullet points:
1.1 Fixes a panic when
okteto up
is executed on a manifest without dev section1.2 Fixes a panic when
okteto up
is executed on a folder without manifest and infering it2.1 Fixes a panic when
okteto init
has to deploy (need to click on yes)2.2 Fixes a panic when
okteto init
is set with k8sLoggerHow to validate
Check that the scenarios described above are working without a panic
CLI Quality Reminders 🔧
For both authors and reviewers: