New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward service ports #609
Conversation
pkg/k8s/pods/pod_test.go
Outdated
t.Run(tt.name, func(t *testing.T) { | ||
c := fake.NewSimpleClientset(ns) | ||
for _, p := range tt.pods { | ||
c.Tracker().Add(&p) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of (k8s.io/client-go/testing.ObjectTracker).Add
is not checked (from errcheck
)
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 40% 37.08% -2.92%
==========================================
Files 35 41 +6
Lines 3090 3559 +469
==========================================
+ Hits 1236 1320 +84
- Misses 1775 2158 +383
- Partials 79 81 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the remote port mandatory as kubectl does. I find it quite confusing to make it optional.
Also, could you document the new syntax?
Yeah, I was doubtful about that one as well. I'll remove it.
|
Fixes #577
Proposed changes
forwards
can now take a string. if a string is given, the forward will go to a service in the namespace instead of to the local dev env@rlamana how do you think we should show this in the CLI's UI? Separate from the forward?
This is how it looks right now. It's sorted so the dev env ports are shown first