Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'okteto login showUrl' shows url, instead open browser #616

Merged
merged 3 commits into from Jan 6, 2020

Conversation

kivi
Copy link
Contributor

@kivi kivi commented Jan 5, 2020

Fixes #615
also outputs the login url on cli, because on wsl2 a browser did not open and login timed out..

Proposed changes

  • typing okteto login [url]
    Results into:

Authentication will continue in your default browser
You can also open a browser and navigate to the following address: https://cloud.okteto.com/github/authorization-code?redirect=someEncodedRedirectUrl
✓ Logged in as loginname
Run okteto namespace to switch your context and download your Kubernetes credentials.

cmd/login.go Outdated Show resolved Hide resolved
cmd/login.go Outdated Show resolved Hide resolved
Copy link
Member

@rberrelleza rberrelleza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good approach, I'd just show the URL all the time for now.

cmd/login.go Outdated Show resolved Hide resolved
cmd/login.go Outdated Show resolved Hide resolved
cmd/login.go Outdated Show resolved Hide resolved
cmd/login.go Outdated Show resolved Hide resolved
cmd/login.go Outdated Show resolved Hide resolved
@rberrelleza rberrelleza merged commit 796aef8 into okteto:master Jan 6, 2020
@rberrelleza
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

okteto login does not open browser or shows url
3 participants