Warning if remote watcher configuration is too low #660
Conversation
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 38.15% 38.29% +0.13%
==========================================
Files 42 42
Lines 3575 3583 +8
==========================================
+ Hits 1364 1372 +8
Misses 2131 2131
Partials 80 80
Continue to review full report at Codecov.
|
cmd/up.go
Outdated
| os.Stderr, | ||
| []string{"sh", "-c", "((cp /var/okteto/bin/* /usr/local/bin); (ps -ef | grep -v -E '/var/okteto/bin/syncthing|/var/okteto/bin/remote|PPID' | awk '{print $2}' | xargs -r kill -9)) >/dev/null 2>&1"}, | ||
| []string{"sh", "-c", "(((cp /var/okteto/bin/* /usr/local/bin); (ps -ef | grep -v -E '/var/okteto/bin/syncthing|/var/okteto/bin/remote|PPID' | awk '{print $2}' | xargs -r kill -9)) >/dev/null 2>&1) || cat /proc/sys/fs/inotify/max_user_watches"}, |
There was a problem hiding this comment.
do we need all the parenthesis?
There was a problem hiding this comment.
It is for readability. We should move this to a proper script/program in the okteto/bin image
cmd/up.go
Outdated
| os.Stderr, | ||
| []string{"sh", "-c", "((cp /var/okteto/bin/* /usr/local/bin); (ps -ef | grep -v -E '/var/okteto/bin/syncthing|/var/okteto/bin/remote|PPID' | awk '{print $2}' | xargs -r kill -9)) >/dev/null 2>&1"}, | ||
| []string{"sh", "-c", "(((cp /var/okteto/bin/* /usr/local/bin); (ps -ef | grep -v -E '/var/okteto/bin/syncthing|/var/okteto/bin/remote|PPID' | awk '{print $2}' | xargs -r kill -9)) >/dev/null 2>&1) || cat /proc/sys/fs/inotify/max_user_watches"}, |
There was a problem hiding this comment.
with the || the final script will only execute if the xargs exits in 1 no?
cmd/utils.go
Outdated
| log.Yellow("We recommend you to raise it to at least 524288 to ensure proper performance.") | ||
| fmt.Println() | ||
| } | ||
| } | ||
|
|
||
| func isWatchesTooLow(value string) bool { |
There was a problem hiding this comment.
| func isWatchesTooLow(value string) bool { | |
| func areWatchesTooLow(value string) bool { |
| log.Yellow("The value of /proc/sys/fs/inotify/max_user_watches is too low. This can affect Okteto's file synchronization performance.") | ||
| if isWatchesTooLow(string(f)) { | ||
| log.Yellow("The value of /proc/sys/fs/inotify/max_user_watches is too low.") | ||
| log.Yellow("This can affect Okteto's file synchronization performance.") | ||
| log.Yellow("We recommend you to raise it to at least 524288 to ensure proper performance.") |
There was a problem hiding this comment.
we are checking for 8192 in the function but on the message we recommend 524288. Is that expected?
There was a problem hiding this comment.
it is the default value. we do the same for local watches
Fixes #610