Support for "okteto redeploy" #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
- Coverage 37.43% 36.89% -0.55%
==========================================
Files 45 49 +4
Lines 3777 3873 +96
==========================================
+ Hits 1414 1429 +15
- Misses 2276 2355 +79
- Partials 87 89 +2
Continue to review full report at Codecov.
|
rberrelleza
reviewed
Feb 12, 2020
| interactive := map[string]string{labels.InteractiveDevLabel: d.Name} | ||
| detached := map[string]string{labels.DetachedDevLabel: d.Name} | ||
|
|
||
| wg := &sync.WaitGroup{} | ||
|
|
||
| wg.Add(1) | ||
| go waitForDevPodsTermination(c, d.Namespace, interactive, wg, t) | ||
| go _waitForDevPodsTermination(c, d.Namespace, interactive, wg, t) |
rberrelleza
reviewed
Feb 12, 2020
pkg/cmd/build/image.go
Outdated
| return imageTag | ||
| } | ||
| if isOktetoCloud { | ||
| return fmt.Sprintf("%s/%s/%s:okteto", okteto.RegistryURL, dev.Namespace, dev.Name) |
There was a problem hiding this comment.
where do we get the RegistryURL from?
rberrelleza
approved these changes
Feb 12, 2020
golangcibot
reviewed
Feb 17, 2020
pkg/cmd/build/buildkit.go
Outdated
|
|
||
| const ( | ||
| frontend = "dockerfile.v0" | ||
| buildKitContainer = "buildkit-0" |
There was a problem hiding this comment.
buildKitContainer is unused (from deadcode)
pkg/cmd/build/buildkit.go
Outdated
| const ( | ||
| frontend = "dockerfile.v0" | ||
| buildKitContainer = "buildkit-0" | ||
| buildKitPort = 1234 |
There was a problem hiding this comment.
buildKitPort is unused (from deadcode)
golangcibot
reviewed
Feb 17, 2020
| @@ -250,6 +250,14 @@ services: | |||
| t.Fatalf("Wrong d1 generation.\nActual %+v, \nExpected %+v", string(marshalled1), string(marshalled1OK)) | |||
| } | |||
|
|
|||
| d1Down, err := translateDevModeOff(d1) | |||
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| @@ -322,6 +330,14 @@ services: | |||
| if string(marshalled2) != string(marshalled2OK) { | |||
| t.Fatalf("Wrong d2 generation.\nActual %s, \nExpected %s", string(marshalled2), string(marshalled2OK)) | |||
| } | |||
|
|
|||
| d2Down, err := translateDevModeOff(d2) | |||
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
Fixes #655