Keep ssh config until down is run #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatnerdjosh
requested review from
pchico83,
rberrelleza and
rlamana
as code owners
thatnerdjosh
force-pushed
the
bugfix/js-fix_okteto_ssh_config
branch
from
2dfcde6
to
3014b3d
Compare
rberrelleza
approved these changes
Feb 20, 2020
|
@NerdsvilleCEO there are merge conflicts, could you update the PR? |
|
Of course @pchico83... It probably got outdated, I'll add a unit test and rebase and then ping once completed |
|
@NerdsvilleCEO It is probably because we are moving logic from the |
Signed-off-by: Josh Santos <josh@omnidapps.com>
thatnerdjosh
force-pushed
the
bugfix/js-fix_okteto_ssh_config
branch
from
3014b3d
to
44c8b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ssh config getting removed on exit of up command (as discussed on slack)