"okteto status" command #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 33.36% 32.51% -0.85%
==========================================
Files 57 58 +1
Lines 4361 4475 +114
==========================================
Hits 1455 1455
- Misses 2811 2925 +114
Partials 95 95
Continue to review full report at Codecov.
|
golangcibot
reviewed
Feb 26, 2020
pkg/syncthing/syncthing.go
Outdated
| configFile = "config.xml" | ||
| logFile = "syncthing.log" | ||
| syncthingPidFile = "syncthing.pid" | ||
| syncthingInfoFile = "syncthing.info" |
There was a problem hiding this comment.
syncthingInfoFile is unused (from deadcode)
pkg/cmd/status/run.go
Outdated
| log.Information("Syncthing password: %s", sy.GUIPassword) | ||
| } | ||
| ctx := context.Background() | ||
| status, err := sy.GetCompletion(ctx, dev) |
There was a problem hiding this comment.
ineffectual assignment to status (from ineffassign)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657
In order to access syncthing from a different command than
okteto up, I need to store the syncthing object to deserialize it in theokteto statuscommand.The
--infoflag show access urls and credentials for the syncthing UI.