Fail if deployment is modified when development environment is active #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rberrelleza
reviewed
Feb 27, 2020
| func UpdateOktetoRevision(ctx context.Context, d *appsv1.Deployment, client *kubernetes.Clientset) error { | ||
| tries := 0 | ||
| ticker := time.NewTicker(200 * time.Millisecond) | ||
| for tries < maxRetriesUpdateRevision { |
There was a problem hiding this comment.
we need to get the revision number that k8s generates on each deployment update, but it usually takes a few ms to generate it
rberrelleza
reviewed
Feb 27, 2020
| @@ -226,6 +227,20 @@ func (up *UpContext) Activate(autoDeploy, resetSyncthing bool) { | |||
| return | |||
| } | |||
|
|
|||
| if up.retry && !deployments.IsDevModeOn(d) { | |||
| log.Information("Development environment has been deactivated") | |||
There was a problem hiding this comment.
we should mention that it was deactivated somewhere else.
rberrelleza
approved these changes
Feb 27, 2020
Co-Authored-By: Ramiro Berrelleza <ramiro@okteto.com>
pchico83
force-pushed
the
k8s-changes
branch
from
3e9cc2b
to
1303ce1
Compare
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 32.26% 31.98% -0.29%
==========================================
Files 58 58
Lines 4509 4549 +40
==========================================
Hits 1455 1455
- Misses 2959 2999 +40
Partials 95 95
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661