Copy using io.Copy instead of os.Rename #732
Conversation
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
1 similar comment
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=======================================
Coverage 31.98% 31.98%
=======================================
Files 59 59
Lines 4627 4627
=======================================
Hits 1480 1480
Misses 3048 3048
Partials 99 99
Continue to review full report at Codecov.
|
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
rberrelleza
force-pushed
the
copy-using-shutil
branch
from
d0ab720
to
8a72d5f
Compare
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
pkg/model/utils_test.go
Outdated
| t.Errorf("fail to detect non-existing file") | ||
| } | ||
|
|
||
| if err := ioutil.WriteFile(p, []byte("hello-world"), 600); err != nil { |
There was a problem hiding this comment.
SA9002: file mode '600' evaluates to 01130; did you mean '0600'? (from staticcheck)
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
pkg/model/utils_test.go
Outdated
| t.Errorf("fail to detect non-existing file") | ||
| } | ||
|
|
||
| if err := ioutil.WriteFile(p, []byte("hello-world"), 600); err != nil { |
There was a problem hiding this comment.
SA9002: file mode '600' evaluates to 01130; did you mean '0600'? (from staticcheck)
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
|
thanks , i happen to met this issue , after upgrade it is fine now. |
Fixes #731