Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with golang 1.14 #738

Merged
merged 2 commits into from
Mar 3, 2020
Merged

build with golang 1.14 #738

merged 2 commits into from
Mar 3, 2020

Conversation

rberrelleza
Copy link
Member

@rberrelleza rberrelleza commented Mar 3, 2020

Build okteto CLI with golang 1.14

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@derek
Copy link

derek bot commented Mar 3, 2020

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the invalid label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #738 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   32.06%   32.06%           
=======================================
  Files          59       59           
  Lines        4615     4615           
=======================================
  Hits         1480     1480           
  Misses       3036     3036           
  Partials       99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7d9d6...46e980b. Read the comment docs.

@derek
Copy link

derek bot commented Mar 3, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Mar 3, 2020
@rberrelleza rberrelleza merged commit b4e8e45 into master Mar 3, 2020
@rberrelleza rberrelleza deleted the golang-1.14 branch March 3, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants