Reconnect if syncthing is not healthy #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
golangcibot
reviewed
Mar 4, 2020
pkg/syncthing/monitor.go
Outdated
| @@ -51,8 +52,8 @@ func (s *Syncthing) Monitor(ctx context.Context, disconnect chan error) { | |||
| continue | |||
| } | |||
| if !connected { | |||
| log.Info("syncthing not connected, sending disconnect signal") | |||
| disconnect <- err | |||
| log.Info("syncthing not connected, sending disconnect signal: %s", err) | |||
There was a problem hiding this comment.
printf: Info call has possible formatting directive %s (from govet)
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 32.06% 31.96% -0.11%
==========================================
Files 59 59
Lines 4615 4627 +12
==========================================
- Hits 1480 1479 -1
- Misses 3036 3049 +13
Partials 99 99
Continue to review full report at Codecov.
|
pchico83
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try and reconnect if we can't talk to syncthing.