Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port forwards over SSH #755

Merged
merged 18 commits into from
Mar 17, 2020
Merged

port forwards over SSH #755

merged 18 commits into from
Mar 17, 2020

Conversation

rberrelleza
Copy link
Member

@rberrelleza rberrelleza commented Mar 9, 2020

option to use SSH forward instead of port-forward for the forward ports.

@derek
Copy link

derek bot commented Mar 9, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek
Copy link

derek bot commented Mar 9, 2020

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

pkg/ssh/manager.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
cmd/up.go Outdated Show resolved Hide resolved
pkg/ssh/manager.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
pkg/ssh/manager_test.go Outdated Show resolved Hide resolved
}),
Addr: address,
Handler: ssh.Handler(func(s ssh.Session) {
io.WriteString(s, "Remote forwarding available...\n")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of io.WriteString is not checked (from errcheck)

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza marked this pull request as ready for review March 17, 2020 19:11
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #755 into master will increase coverage by 1.38%.
The diff coverage is 53.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   30.59%   31.98%   +1.38%     
==========================================
  Files          59       62       +3     
  Lines        4677     4821     +144     
==========================================
+ Hits         1431     1542     +111     
- Misses       3148     3159      +11     
- Partials       98      120      +22
Impacted Files Coverage Δ
pkg/syncthing/syncthing.go 0.57% <ø> (ø) ⬆️
cmd/up.go 0% <0%> (ø) ⬆️
pkg/k8s/forward/manager.go 31.38% <0%> (-0.47%) ⬇️
pkg/model/dev.go 64.66% <20%> (-1.01%) ⬇️
pkg/ssh/pool.go 54.16% <54.16%> (ø)
pkg/ssh/forward.go 71.42% <71.42%> (ø)
pkg/ssh/manager.go 72.09% <72.09%> (ø)
pkg/ssh/reverse.go 72.72% <73.17%> (+61.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1d9af...4a6433a. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 2062e42 into master Mar 17, 2020
@rberrelleza rberrelleza deleted the forward-via-ssh branch March 17, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants