-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port forwards over SSH #755
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description. |
30245bc
to
40682bd
Compare
pkg/ssh/manager_test.go
Outdated
}), | ||
Addr: address, | ||
Handler: ssh.Handler(func(s ssh.Session) { | ||
io.WriteString(s, "Remote forwarding available...\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of io.WriteString
is not checked (from errcheck
)
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
1350f6e
to
3a7d4ef
Compare
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 30.59% 31.98% +1.38%
==========================================
Files 59 62 +3
Lines 4677 4821 +144
==========================================
+ Hits 1431 1542 +111
- Misses 3148 3159 +11
- Partials 98 120 +22
Continue to review full report at Codecov.
|
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
option to use SSH forward instead of port-forward for the
forward
ports.