Support for "--plain" option to show plain build container output #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 30.77% 30.73% -0.04%
==========================================
Files 59 59
Lines 4644 4650 +6
==========================================
Hits 1429 1429
- Misses 3117 3123 +6
Partials 98 98
Continue to review full report at Codecov.
|
rberrelleza
approved these changes
Mar 16, 2020
cmd/build.go
Outdated
| @@ -64,6 +65,7 @@ func Build() *cobra.Command { | |||
| cmd.Flags().StringVarP(&tag, "tag", "t", "", "name and optionally a tag in the 'name:tag' format (it is automatically pushed)") | |||
| cmd.Flags().StringVarP(&target, "target", "", "", "set the target build stage to build") | |||
| cmd.Flags().BoolVarP(&noCache, "no-cache", "", false, "do not use cache when building the image") | |||
| cmd.Flags().BoolVarP(&plain, "plain", "", false, "show plain build container output") | |||
There was a problem hiding this comment.
I'd use the same format as buildkit: --progress=plain and --progress=tty as the default?
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
rberrelleza
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to show plain build container output.
Buildkit does not show the output of "RUN" instructions by default. "--plain" is useful for debugging Dockerfile scenarios.
Ideally, we should parse the buildkit output and show the info as we prefer, but that requires a lot of work.