-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a message on "okteto down" for discoverability of "okteto push" #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this, I don't think it provides any value to the user and it's kind of annoying to see it everytime you run down.
@rberrelleza I honestly see a lot of value in providing information and helping the discoverability of other features in the tool, which is hard to achieve in a CLI tool. As an example of other tools doing something similar, $ git status
On branch master
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: index.html
no changes added to commit (use "git add" and/or "git commit -a") All that to help users with next steps and feature discoverability. And that one is pretty verbose and we use it all the time. I think the one @pchico83 proposes is not that intrusive or annoying. And |
@rberrelleza we could maybe create a different kind of information output that is not so prominent, instead of the intense blue we use for information. Would that help to make it less annoying? |
cmd/down.go
Outdated
@@ -53,6 +53,7 @@ func Down() *cobra.Command { | |||
} | |||
|
|||
log.Success("Development environment deactivated") | |||
log.Information("Execute 'okteto push' to permanently apply your changes to your cluster") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Information("Execute 'okteto push' to permanently apply your changes to your cluster") | |
log.Information("Run 'okteto push' to deploy your local changes in your cluster") |
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
- Coverage 31.99% 31.98% -0.01%
==========================================
Files 62 62
Lines 4820 4821 +1
==========================================
Hits 1542 1542
- Misses 3159 3160 +1
Partials 119 119
Continue to review full report at Codecov.
|
Proposed changes