reduce log frequency #772
Merged
reduce log frequency #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 31.99% 31.99% -0.01%
==========================================
Files 62 62
Lines 4819 4820 +1
==========================================
Hits 1542 1542
- Misses 3158 3159 +1
Partials 119 119
Continue to review full report at Codecov.
|
pchico83
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sync goes wrong, this line gets logged once every 100 milliseconds, making the logs hard to parse. I think having one log every 10 seconds should be enough for diagnosis.