Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move SSH file atomically #773

Merged
merged 2 commits into from
Mar 21, 2020
Merged

move SSH file atomically #773

merged 2 commits into from
Mar 21, 2020

Conversation

rberrelleza
Copy link
Member

I think this should help with the ssh config corruption issue we've seen every now and then.
Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #773 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   31.98%   31.95%   -0.04%     
==========================================
  Files          62       62              
  Lines        4821     4829       +8     
==========================================
+ Hits         1542     1543       +1     
- Misses       3160     3165       +5     
- Partials      119      121       +2
Impacted Files Coverage Δ
pkg/ssh/ssh.go 74.19% <0%> (ø) ⬆️
cmd/up.go 0% <0%> (ø) ⬆️
pkg/ssh/config.go 74.24% <23.52%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2205f4...b85cb81. Read the comment docs.

@derek derek bot added the no-dco label Mar 21, 2020
@derek
Copy link

derek bot commented Mar 21, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@rberrelleza rberrelleza merged commit 191b8e8 into master Mar 21, 2020
@rberrelleza rberrelleza deleted the atomic-ssh-update branch March 21, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants