Generate ssh key

[rberrelleza]

This is part of #475

Proposed changes

• Generate an SSH key pair
• Add it to the SSH configuration

By itself, this doesn't do anything until remote accepts public key authentication

I decided to create a separate key to keep it separately from existing setup. This is something we could even use later for access to other services (like buildkit). Another option is to use the users's private/public keys for this. what do you think?

[codecov]

Codecov Report

Merging #774 into master will increase coverage by 0.50%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   31.93%   32.44%   +0.50%     
==========================================
  Files          62       63       +1     
  Lines        4831     4931     +100     
==========================================
+ Hits         1543     1600      +57     
- Misses       3167     3199      +32     
- Partials      121      132      +11     

Impacted Files	Coverage Δ
cmd/dependencies.go	0.00% <0.00%> (ø)
cmd/up.go	0.00% <0.00%> (ø)
cmd/version.go	27.65% <0.00%> (-0.61%)	⬇️
pkg/ssh/config.go	74.24% <ø> (ø)
pkg/ssh/exec.go	0.00% <0.00%> (ø)
pkg/ssh/manager.go	68.88% <33.33%> (-3.21%)	⬇️
pkg/ssh/key.go	65.51% <65.51%> (ø)
pkg/ssh/client.go	71.42% <70.00%> (-28.58%)	⬇️
pkg/model/dev.go	65.14% <72.72%> (+0.47%)	⬆️
pkg/ssh/ssh.go	75.00% <100.00%> (+0.80%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3ba4e...28dc667. Read the comment docs.

[pchico83]

I would go with this approach too.
I wouldn't show any output related to SSH, I think it is an implementation detail, but we can do that later when we consolidate the ssh implementation.

[rberrelleza]

I wouldn't show any output related to SSH, I think it is an implementation detail, but we can do that later when we consolidate the ssh implementation.

That's somethign that I've been thinking about as well. We need to show output because generating those keys takes about 10 seconds. Maybe change the text to just talk about generating key pair?

[pchico83]

@rberrelleza yes, for now I would go with this implementation. in the future, we can abstract SSH away and don't show anything ssh related in the output

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[rberrelleza]

@pchico83 @rlamana what do you think of the message?

[pchico83]

@pchico83 @rlamana what do you think of the message?

Love it!