Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple "push" and "down" implementations #778

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Decouple "push" and "down" implementations #778

merged 2 commits into from
Mar 25, 2020

Conversation

pchico83
Copy link
Contributor

Fixes #777

@derek
Copy link

derek bot commented Mar 24, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #778 into master will decrease coverage by 0.08%.
The diff coverage is 2.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   32.44%   32.36%   -0.09%     
==========================================
  Files          63       63              
  Lines        4931     4944      +13     
==========================================
  Hits         1600     1600              
- Misses       3199     3212      +13     
  Partials      132      132
Impacted Files Coverage Δ
cmd/push.go 0% <0%> (ø) ⬆️
cmd/down.go 0% <0%> (ø) ⬆️
pkg/cmd/down/run.go 0% <0%> (ø) ⬆️
pkg/k8s/deployments/crud.go 10.1% <14.28%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5d6b7...8cb4b5a. Read the comment docs.

// UpdateDeployments update all deployments in the given translaation list
func UpdateDeployments(trList map[string]*model.Translation, c *kubernetes.Clientset) error {
for _, tr := range trList {
if tr.Deployment == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would deployment be nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for the case it is created by up or push

@derek derek bot added the no-dco label Mar 25, 2020
@derek
Copy link

derek bot commented Mar 25, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

pchico83 and others added 2 commits March 25, 2020 07:05
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Co-Authored-By: Ramiro Berrelleza <ramiro@okteto.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"okteto push" does not work if "okteto up" is active
2 participants