-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple "push" and "down" implementations #778
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 32.44% 32.36% -0.09%
==========================================
Files 63 63
Lines 4931 4944 +13
==========================================
Hits 1600 1600
- Misses 3199 3212 +13
Partials 132 132
Continue to review full report at Codecov.
|
// UpdateDeployments update all deployments in the given translaation list | ||
func UpdateDeployments(trList map[string]*model.Translation, c *kubernetes.Clientset) error { | ||
for _, tr := range trList { | ||
if tr.Deployment == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would deployment be nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for the case it is created by up
or push
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Co-Authored-By: Ramiro Berrelleza <ramiro@okteto.com> Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Fixes #777