Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: test writable install directory #780

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 25, 2020

The current script requires sudo, even /usr/local/bin is writable for a non-privileged user

@derek
Copy link

derek bot commented Mar 25, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

current script requires sudo, even /usr/local/bin is writable for non-privileged user

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #780 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   32.36%   32.36%           
=======================================
  Files          63       63           
  Lines        4944     4944           
=======================================
  Hits         1600     1600           
  Misses       3212     3212           
  Partials      132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3951161...1775c3b. Read the comment docs.

@derek derek bot removed the no-dco label Mar 25, 2020
@rberrelleza
Copy link
Member

CI failure is unrelated, I'll fix it in a separate PR.

@rberrelleza rberrelleza merged commit 6bda277 into okteto:master Mar 25, 2020
@rberrelleza
Copy link
Member

Thanks for the contribution @glensc !

@glensc glensc deleted the patch-1 branch March 26, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants