Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep image content if persistentVolume.enabled is false #782

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

pchico83
Copy link
Contributor

Related to #764

If persistentVolume is not enabled, this PR does not mount an emptyDir on the working dir, and the content of the image is not lost. In a later iteration this will be the default behavior

@derek
Copy link

derek bot commented Mar 25, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #782 into master will increase coverage by 0.03%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   32.36%   32.39%   +0.03%     
==========================================
  Files          63       63              
  Lines        4944     4951       +7     
==========================================
+ Hits         1600     1604       +4     
- Misses       3212     3215       +3     
  Partials      132      132
Impacted Files Coverage Δ
cmd/up.go 0% <0%> (ø) ⬆️
pkg/model/dev.go 65.17% <80%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a14cc...19914c7. Read the comment docs.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@pchico83 pchico83 merged commit 3be78fe into master Mar 26, 2020
@pchico83 pchico83 deleted the keep-image-content branch March 26, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants