Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: use temporary download #784

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 26, 2020

improves installer:

  1. download to a temporary file to prevent partially downloaded executable
  2. use sudo only for move package

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3be78fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #784   +/-   ##
=========================================
  Coverage          ?   32.39%           
=========================================
  Files             ?       63           
  Lines             ?     4951           
  Branches          ?        0           
=========================================
  Hits              ?     1604           
  Misses            ?     3215           
  Partials          ?      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be78fe...e5de613. Read the comment docs.

@rberrelleza rberrelleza merged commit 2e3cfdb into okteto:master Mar 27, 2020
@glensc glensc deleted the installer-tmp branch March 28, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants