Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward the SSH_AUTH_SOCK in Go client #848

Merged

Conversation

unthought
Copy link
Contributor

@unthought unthought commented Apr 30, 2020

Fixes #845

Proposed changes

  • forward the ssh agent socket found at SSH_AUTH_SOCK (if set) to remote, during okteto up and okteto exec.
  • currently if the SSH_AUTH_SOCK env var is set, it's forwarded unconditionally. We might want to allow the user to disable this.

@derek
Copy link

derek bot commented Apr 30, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #848 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   33.12%   33.07%   -0.06%     
==========================================
  Files          67       67              
  Lines        5217     5225       +8     
==========================================
  Hits         1728     1728              
- Misses       3346     3354       +8     
  Partials      143      143              
Impacted Files Coverage Δ
pkg/ssh/exec.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f649fd...0ceaf27. Read the comment docs.

@unthought unthought force-pushed the unthought/fix/forward-ssh-auth-sock-in-go branch from 513d9a4 to 56f572b Compare April 30, 2020 14:13
@derek derek bot removed the no-dco label Apr 30, 2020
@unthought unthought force-pushed the unthought/fix/forward-ssh-auth-sock-in-go branch from 56f572b to 45ef7fa Compare April 30, 2020 14:48
Copy link
Member

@rberrelleza rberrelleza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added couple of comments on changes I think should be done.

pkg/ssh/exec.go Outdated Show resolved Hide resolved
pkg/ssh/exec.go Outdated Show resolved Hide resolved
Fixes okteto#845

Signed-off-by: Daniel Müller <dan@unthought.org>
@unthought unthought force-pushed the unthought/fix/forward-ssh-auth-sock-in-go branch from 45ef7fa to 0ceaf27 Compare April 30, 2020 18:03
Copy link
Contributor

@pchico83 pchico83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution. Thanks @unthought!

@rberrelleza rberrelleza merged commit 7ec77d3 into okteto:master Apr 30, 2020
@unthought unthought deleted the unthought/fix/forward-ssh-auth-sock-in-go branch April 30, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the shell started by okteto up doesn't forward the SSH agent
3 participants