-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forward the SSH_AUTH_SOCK in Go client #848
forward the SSH_AUTH_SOCK in Go client #848
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
- Coverage 33.12% 33.07% -0.06%
==========================================
Files 67 67
Lines 5217 5225 +8
==========================================
Hits 1728 1728
- Misses 3346 3354 +8
Partials 143 143
Continue to review full report at Codecov.
|
513d9a4
to
56f572b
Compare
56f572b
to
45ef7fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, added couple of comments on changes I think should be done.
Fixes okteto#845 Signed-off-by: Daniel Müller <dan@unthought.org>
45ef7fa
to
0ceaf27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contribution. Thanks @unthought!
Fixes #845
Proposed changes
SSH_AUTH_SOCK
(if set) to remote, duringokteto up
andokteto exec
.SSH_AUTH_SOCK
env var is set, it's forwarded unconditionally. We might want to allow the user to disable this.