Set healthchecks based on "healthchecks" field #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
- Coverage 33.07% 33.05% -0.02%
==========================================
Files 67 67
Lines 5225 5224 -1
==========================================
- Hits 1728 1727 -1
Misses 3354 3354
Partials 143 143
Continue to review full report at Codecov.
|
rberrelleza
reviewed
May 1, 2020
| @@ -99,6 +99,7 @@ type Dev struct { | |||
| Environment []EnvVar `json:"environment,omitempty" yaml:"environment,omitempty"` | |||
| Secrets []Secret `json:"secrets,omitempty" yaml:"secrets,omitempty"` | |||
| Command []string `json:"command,omitempty" yaml:"command,omitempty"` | |||
| Healthchecks bool `json:"healthchecks,omitempty" yaml:"healthchecks,omitempty"` | |||
There was a problem hiding this comment.
would this make them on or off by default?
There was a problem hiding this comment.
it disables them by default
rberrelleza
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #849