Add pid file creation for okteto up command.

[adhaamehab]

Signed-off-by: adhaamehab adhaamehab.me@gmail.com

Fixes #691

Proposed changes

• Okteto Up generates a namespace-deployment.pid file at .okteto/ folder defined in the $OKTETOHOME
• The pid file gets deleted once okteto up finishes
• If the namespace isn't defined in okteto.yml file or --namespace flag. we use the namespace provided by the k8s client

[codecov]

Codecov Report

Merging #860 into master will decrease coverage by 0.00%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   33.14%   33.13%   -0.01%     
==========================================
  Files          67       67              
  Lines        5253     5275      +22     
==========================================
+ Hits         1741     1748       +7     
- Misses       3369     3381      +12     
- Partials      143      146       +3     

Impacted Files	Coverage Δ
cmd/up.go	6.23% <38.88%> (+1.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e32f8a...ecbfa09. Read the comment docs.

[rberrelleza]

Looks good! Minor comments added.

[pchico83]

The namespace value might come from the namespace flag too.
dev.Namespace is initialized at this point:

okteto/cmd/up.go

Line 230 in 67e1c71

}

The RunUp logic is a bit messy, we need to refactor it. But you could bring the dev.Namespace initialization logic here if needed

[adhaamehab]

Sorry, @pchico83 I'm a little bit confused because the referenced line is older than the current. Can you explain more?

[pchico83]

Sure. In the master branch, dev.Namespace is initialized in lines 220-230 in cmd/up.go.
I think you can move that logic here to have a single place where where k8Client.GetLocal() is called:

[adhaamehab]

Got it, thanks.
Will do so 👍🏻

[adhaamehab]

@rberrelleza @pchico83
Can you review the latest changes whenever you have time?

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[rberrelleza]

Thanks for adding the test, looks great!

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.