Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting issues #865

Merged
merged 6 commits into from
May 6, 2020
Merged

Linting issues #865

merged 6 commits into from
May 6, 2020

Conversation

rberrelleza
Copy link
Member

Fix issues flagged by the linter

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@derek
Copy link

derek bot commented May 6, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #865 into master will increase coverage by 0.00%.
The diff coverage is 53.48%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   33.22%   33.23%           
=======================================
  Files          67       67           
  Lines        5282     5275    -7     
=======================================
- Hits         1755     1753    -2     
+ Misses       3381     3376    -5     
  Partials      146      146           
Impacted Files Coverage Δ
cmd/exec.go 0.00% <0.00%> (ø)
cmd/login.go 7.04% <0.00%> (ø)
cmd/upState.go 0.00% <0.00%> (ø)
pkg/cmd/build/buildkit.go 0.00% <0.00%> (ø)
pkg/model/dev.go 64.57% <0.00%> (-0.09%) ⬇️
pkg/okteto/auth.go 19.27% <0.00%> (+0.22%) ⬆️
pkg/k8s/deployments/crud.go 10.21% <33.33%> (+0.10%) ⬆️
pkg/k8s/deployments/translate.go 84.42% <50.00%> (ø)
pkg/cmd/build/image.go 54.54% <57.14%> (ø)
pkg/k8s/pods/pod.go 14.60% <75.00%> (-0.45%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b089a...13564c7. Read the comment docs.

rberrelleza and others added 2 commits May 5, 2020 21:42
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit d660a01 into master May 6, 2020
@rberrelleza rberrelleza deleted the linting-issues branch May 6, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant