Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail if we can't set terminal to RAW mode #877

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

rberrelleza
Copy link
Member

In my tests, not being able to enable RAW mode only had one side-effect, the terminal will echo every command (ugly, but not end of the world).

I think it's better to not fail the command, even if we offer a degraded experience. On the side, I'm doing some testing to try and figure out the root cause of #876

Proposed changes

  • Log the error that comes from terminal.Raw and keep going
  • Get the terminal size, and fallback on a default on error

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #877 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   33.41%   33.32%   -0.10%     
==========================================
  Files          67       67              
  Lines        5291     5306      +15     
==========================================
  Hits         1768     1768              
- Misses       3375     3390      +15     
  Partials      148      148              
Impacted Files Coverage Δ
pkg/ssh/exec.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8aef1...7a24012. Read the comment docs.

@rberrelleza rberrelleza merged commit 971ddde into master May 20, 2020
@rberrelleza rberrelleza deleted the dont-fail-on-raw branch May 20, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant