don't fail if we can't set terminal to RAW mode #877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests, not being able to enable RAW mode only had one side-effect, the terminal will echo every command (ugly, but not end of the world).
I think it's better to not fail the command, even if we offer a degraded experience. On the side, I'm doing some testing to try and figure out the root cause of #876
Proposed changes
terminal.Raw
and keep goingSigned-off-by: Ramiro Berrelleza rberrelleza@gmail.com