Support for variable expansion in the "name" field #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 33.33% 33.41% +0.07%
==========================================
Files 67 67
Lines 5285 5291 +6
==========================================
+ Hits 1762 1768 +6
Misses 3375 3375
Partials 148 148
Continue to review full report at Codecov.
|
rberrelleza
reviewed
May 18, 2020
| @@ -273,6 +277,12 @@ func Read(bytes []byte) (*Dev, error) { | |||
| return dev, nil | |||
| } | |||
|
|
|||
| func (dev *Dev) loadName() { | |||
| if len(dev.Name) > 0 { | |||
| dev.Name = os.ExpandEnv(dev.Name) | |||
There was a problem hiding this comment.
will this support env vars with a default value ? ${foo-NAME} kind of thing.
rberrelleza
approved these changes
May 18, 2020
|
@rberrelleza let's track that as part of #874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #880