Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only load body if required #887

Merged
merged 3 commits into from
Jun 1, 2020
Merged

only load body if required #887

merged 3 commits into from
Jun 1, 2020

Conversation

rberrelleza
Copy link
Member

When restarting syncthing, sometimes we get an EOF error because the process restarts before we consume the response. With this change, we only get the body of the response if when we care about it.

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #887 into master will decrease coverage by 0.00%.
The diff coverage is 2.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   33.32%   33.31%   -0.01%     
==========================================
  Files          67       67              
  Lines        5306     5307       +1     
==========================================
  Hits         1768     1768              
- Misses       3390     3391       +1     
  Partials      148      148              
Impacted Files Coverage Δ
pkg/syncthing/api.go 0.00% <0.00%> (ø)
pkg/syncthing/syncthing.go 0.54% <0.00%> (+<0.01%) ⬆️
cmd/up.go 6.28% <14.28%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971ddde...ee45fd9. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 1944ebf into master Jun 1, 2020
@rberrelleza rberrelleza deleted the retry-on-eof branch June 1, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants