-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move okteto/bin and okteto/okteto to the cli repo #889
Conversation
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 33.48% 33.48%
=======================================
Files 67 67
Lines 5337 5337
=======================================
Hits 1787 1787
Misses 3404 3404
Partials 146 146 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
Should we move these files under a folder images/bin
?
Having them at the root level gives the impression that this is dockerizing the cli itself.
The dockerfile generates okteto/bin and okteto/okteto (which is currently consumed by the github actions), I put it in root so it can add the source. We could back to instead building separately and just ADD the binary into the container. what do you think? |
@rberrelleza LGTM |
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
…to move-dockerfile-in-repo
Proposed changes
As a follow up, we can update our release job so everything is generated together.
Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com