Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move okteto/bin and okteto/okteto to the cli repo #889

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • Move the okteto/bin and okteto/okteto docker files to the CLI repo, since they all depend on each other

As a follow up, we can update our release job so everything is generated together.

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files          67       67           
  Lines        5337     5337           
=======================================
  Hits         1787     1787           
  Misses       3404     3404           
  Partials      146      146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c09ef...adeaad2. Read the comment docs.

Copy link
Contributor

@pchico83 pchico83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!
Should we move these files under a folder images/bin?
Having them at the root level gives the impression that this is dockerizing the cli itself.

@rberrelleza
Copy link
Member Author

The dockerfile generates okteto/bin and okteto/okteto (which is currently consumed by the github actions), I put it in root so it can add the source.

We could back to instead building separately and just ADD the binary into the container. what do you think?

@pchico83
Copy link
Contributor

pchico83 commented Jun 4, 2020

@rberrelleza LGTM

@derek derek bot added the no-dco label Jun 4, 2020
@derek
Copy link

derek bot commented Jun 4, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 0a90e8c into master Jun 4, 2020
@rberrelleza rberrelleza deleted the move-dockerfile-in-repo branch June 4, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants