Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share namespace #890

Merged
merged 7 commits into from
Jun 4, 2020
Merged

share namespace #890

merged 7 commits into from
Jun 4, 2020

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • add a parameter to create namespace to invite other okteto users

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@derek derek bot added the no-dco label Jun 4, 2020
@derek
Copy link

derek bot commented Jun 4, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #890 into master will decrease coverage by 0.00%.
The diff coverage is 20.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   33.44%   33.43%   -0.01%     
==========================================
  Files          67       67              
  Lines        5311     5332      +21     
==========================================
+ Hits         1776     1783       +7     
- Misses       3389     3403      +14     
  Partials      146      146              
Impacted Files Coverage Δ
pkg/okteto/client.go 39.74% <0.00%> (-3.92%) ⬇️
pkg/okteto/namespace.go 20.58% <41.17%> (+20.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1d2e0...a0df969. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 49e4ae1 into master Jun 4, 2020
@rberrelleza rberrelleza deleted the share-namespace branch June 4, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants