Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev annotations both, to the pod and the deployment metadata #892

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Jun 4, 2020

Fixes #891

@derek derek bot added the no-dco label Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #892 into master will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   33.31%   33.36%   +0.05%     
==========================================
  Files          67       67              
  Lines        5307     5311       +4     
==========================================
+ Hits         1768     1772       +4     
- Misses       3391     3393       +2     
+ Partials      148      146       -2     
Impacted Files Coverage Δ
pkg/k8s/deployments/crud.go 10.05% <0.00%> (-0.17%) ⬇️
pkg/k8s/deployments/translate.go 85.17% <100.00%> (+0.74%) ⬆️
pkg/k8s/deployments/utils.go 82.75% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1944ebf...2bf0850. Read the comment docs.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@derek derek bot removed the no-dco label Jun 4, 2020
@okteto okteto deleted a comment from derek bot Jun 4, 2020
@derek derek bot added the no-dco label Jun 4, 2020
@derek
Copy link

derek bot commented Jun 4, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@derek derek bot removed the no-dco label Jun 4, 2020
@pchico83 pchico83 merged commit 961a294 into master Jun 4, 2020
@pchico83 pchico83 deleted the annotations branch June 4, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"okteto up" breaks Flux deployments
1 participant