Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting dev time tolerations #893

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Support for setting dev time tolerations #893

merged 1 commit into from
Jun 4, 2020

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Jun 4, 2020

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Fixes #888

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #893 into master will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   33.36%   33.44%   +0.07%     
==========================================
  Files          67       67              
  Lines        5311     5311              
==========================================
+ Hits         1772     1776       +4     
+ Misses       3393     3389       -4     
  Partials      146      146              
Impacted Files Coverage Δ
pkg/model/dev.go 65.18% <ø> (ø)
pkg/model/translation.go 0.00% <ø> (ø)
pkg/k8s/deployments/crud.go 10.75% <11.11%> (+0.69%) ⬆️
pkg/k8s/deployments/translate.go 85.32% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961a294...7144e7b. Read the comment docs.

@pchico83
Copy link
Contributor Author

pchico83 commented Jun 4, 2020

Also fixes integration tests

@pchico83 pchico83 merged commit 3c1d2e0 into master Jun 4, 2020
@pchico83 pchico83 deleted the tolerations branch June 4, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tolerations in okteto manifest
1 participant