Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info in the output when authentication fails #894

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

rberrelleza
Copy link
Member

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@derek derek bot added the no-dco label Jun 4, 2020
@derek
Copy link

derek bot commented Jun 4, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #894 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   33.48%   33.48%   -0.01%     
==========================================
  Files          67       67              
  Lines        5336     5337       +1     
==========================================
  Hits         1787     1787              
- Misses       3403     3404       +1     
  Partials      146      146              
Impacted Files Coverage Δ
pkg/okteto/auth.go 19.16% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e8c40...ebba903. Read the comment docs.

@rberrelleza rberrelleza merged commit 10c09ef into master Jun 4, 2020
@rberrelleza rberrelleza deleted the friendly-auth-errors branch June 4, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants