Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail early if requirements are not fulfilled #896

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • fail the up cycle earlier if a requirement is not fulfilled
  • improve error messages

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #896 into master will increase coverage by 0.01%.
The diff coverage is 8.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   33.48%   33.49%   +0.01%     
==========================================
  Files          67       67              
  Lines        5337     5335       -2     
==========================================
  Hits         1787     1787              
+ Misses       3404     3402       -2     
  Partials      146      146              
Impacted Files Coverage Δ
cmd/up.go 6.30% <0.00%> (+0.02%) ⬆️
pkg/ssh/manager.go 67.39% <ø> (ø)
pkg/model/dev.go 65.18% <100.00%> (ø)
pkg/okteto/client.go 42.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8246b6e...be781e5. Read the comment docs.

@derek derek bot added the no-dco label Jun 5, 2020
@derek
Copy link

derek bot commented Jun 5, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@rberrelleza rberrelleza merged commit ee167fb into master Jun 5, 2020
@rberrelleza rberrelleza deleted the fail-early branch June 5, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants