Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set replicas to 1 on push #899

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Set replicas to 1 on push #899

merged 2 commits into from
Jun 5, 2020

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • Set the replicas to 1 when push if they are zero
  • Breakup function into smaller bits

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #899 into master will increase coverage by 0.19%.
The diff coverage is 5.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   33.30%   33.50%   +0.19%     
==========================================
  Files          67       67              
  Lines        5365     5340      -25     
==========================================
+ Hits         1787     1789       +2     
+ Misses       3432     3404      -28     
- Partials      146      147       +1     
Impacted Files Coverage Δ
cmd/push.go 0.00% <0.00%> (ø)
cmd/up.go 6.28% <0.00%> (-0.03%) ⬇️
pkg/cmd/down/run.go 0.00% <0.00%> (ø)
pkg/k8s/services/translate.go 0.00% <ø> (ø)
pkg/model/dev.go 65.18% <0.00%> (ø)
pkg/k8s/deployments/crud.go 11.57% <17.64%> (+0.82%) ⬆️
cmd/down.go 0.00% <0.00%> (ø)
pkg/ssh/manager.go 67.39% <0.00%> (ø)
pkg/okteto/client.go 42.68% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f1529...228fa95. Read the comment docs.

cmd/push.go Outdated
spinner := utils.NewSpinner(fmt.Sprintf("Pushing source code to the development environment '%s'...", dev.Name))
spinner.Start()
defer spinner.Stop()

if create {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this recreating the service?
I think it is not. It could work if you check the deployment autocreate annotation instead of the create envvar.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@derek derek bot added the no-dco label Jun 5, 2020
@derek
Copy link

derek bot commented Jun 5, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@pchico83 pchico83 merged commit 286a67c into master Jun 5, 2020
@pchico83 pchico83 deleted the push-wakeup branch June 5, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants