-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set replicas to 1 on push #899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 33.30% 33.50% +0.19%
==========================================
Files 67 67
Lines 5365 5340 -25
==========================================
+ Hits 1787 1789 +2
+ Misses 3432 3404 -28
- Partials 146 147 +1
Continue to review full report at Codecov.
|
cmd/push.go
Outdated
spinner := utils.NewSpinner(fmt.Sprintf("Pushing source code to the development environment '%s'...", dev.Name)) | ||
spinner.Start() | ||
defer spinner.Stop() | ||
|
||
if create { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this recreating the service?
I think it is not. It could work if you check the deployment autocreate annotation instead of the create
envvar.
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Proposed changes