Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus README.md on swap development mode #909

Merged
merged 4 commits into from Jun 12, 2020
Merged

Focus README.md on swap development mode #909

merged 4 commits into from Jun 12, 2020

Conversation

pchico83
Copy link
Contributor

Also, add a more visual explanation for the concept of developing in a container

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #909 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   33.36%   33.37%           
=======================================
  Files          67       67           
  Lines        5380     5379    -1     
=======================================
  Hits         1795     1795           
+ Misses       3436     3435    -1     
  Partials      149      149           
Impacted Files Coverage Δ
pkg/k8s/pods/pod.go 14.53% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353d418...d06246b. Read the comment docs.

@pchico83 pchico83 force-pushed the init branch 2 times, most recently from 060a527 to f0ccaf1 Compare June 10, 2020 14:48
README.md Outdated

Okteto supports applications with one or with multiple services.
- Keep files synchronized both ways between your laptop and your deployment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is not consistent with the previous paragraph, since this are not "things you can define" but rather actions okteto up performs for you

README.md Outdated Show resolved Hide resolved
README.md Outdated

Okteto detects your code changes and synchronizes your code to your development environment (powered by [Syncthing](https://github.com/syncthing/syncthing)). Files are synchronized both ways. If you edit a file directly in your development environment, the changes will be reflected locally as well. Great for keeping your `package-lock.json` or `requirements.txt` up to date.
Okteto developer mode has several adantages versus tradicional development:
- Relaunch your application from your development container with your latest code changes. Native builds are always faster than the *docker build/redeploy* cycle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? We don't talk about developer container at all on the readme. I think it's a good concept but we should then introduce it earlier on and explain what are we talking about.

README.md Outdated
Okteto developer mode has several adantages versus tradicional development:
- Relaunch your application from your development container with your latest code changes. Native builds are always faster than the *docker build/redeploy* cycle.
- Eliminate integration issues. Your development container reuses the same variables, secrets, sidecards, volumes... than your original Kubernetes deployment.
- Hardware and network just limited by the power of your cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this?

README.md Outdated
- Eliminate integration issues. Your development container reuses the same variables, secrets, sidecards, volumes... than your original Kubernetes deployment.
- Hardware and network just limited by the power of your cluster.

Okteto supports applications with one or with multiple services. If your okteto manifest does not match a running deployment, a new deployment is created on the fly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this paragraph, I think it just confuses.

README.md Outdated Show resolved Hide resolved
README.md Outdated
- Run `okteto up` to launch your development environment in seconds.

Add `okteto.yml` to your repo and make collaboration easier than ever. Clone the repository and simply run `okteto up` to launch a fully configured development environment.

### Developer Mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should start with the diagram and talking about how okteto up swaps a piece of your application with your developer container. And then get the rest of things that happen (file sync, port forwards, SSH server, etc...)

@derek
Copy link

derek bot commented Jun 11, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.


You can also directly download the precompiled binary from [the releases page](https://github.com/okteto/okteto/releases).
![Okteto](docs/okteto-architecture.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I can update the diagram to use the concepts of "development container" in it, and make some other improvements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be cool. I am going to merge it, but if you can, update the image later.

README.md Outdated

Okteto easily integrates and augments your existing tools. You write code locally, which means Okteto is compatible with any IDE. And you can configure your own development environment runtime using a docker image, with your own compilers, linters, debuggers or hot reloaders.
All you need to get started is to [install the Okteto CLI](https://okteto.com/docs/getting-started/installation/index.html) and have access to a Kubernetes cluster. You can also use Okteto in [Okteto Cloud](https://okteto.com/), the best development platform for Kubernetes applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the best development platform for Kubernetes applications, I know this was already there but it still sounds odd to me. Maybe something like our hosted development platform for Kubernetes applications or our approach to a hosted development platform for Kubernetes applications on top of Okteto.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove that last sentence.

pchico83 and others added 4 commits June 12, 2020 10:34
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants